Storm

Merge lp:~cjwatson/storm/py314-beta into lp:storm

Proposed by Colin Watson on 2025-05-13

Status:	Merged
Merged at revision:	590
Proposed branch:	lp:~cjwatson/storm/py314-beta
Merge into:	lp:storm
Diff against target:	36 lines (+4/-0) 3 files modified NEWS (+1/-0) storm/sqlobject.py (+2/-0) tox.ini (+1/-0)
To merge this branch:	bzr merge lp:~cjwatson/storm/py314-beta
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Guruprasad		2025-05-13	Approve on 2025-05-23
Review via email: mp+485763@code.launchpad.net

Add preliminary support for Python 3.14.

Python 3.14 is still only in beta, and I couldn't find the exact change that triggered this, but the fix seems in line with a similar change in https://code.launchpad.net/~cjwatson/storm/py36/+merge/373380, so I guess it's fair enough.

Revision history for this message

Guruprasad (lgp171188) wrote on 2025-05-23:

LGTM 👍 Thanks!

review: Approve

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

People subscribed via source and target branches

to all changes:

to status/vote changes:

1	=== modified file 'NEWS'
2	--- NEWS 2024-10-14 10:00:56 +0000
3	+++ NEWS 2025-05-13 17:04:35 +0000
4	@@ -6,6 +6,7 @@
5
6	- Remove test dependency on pkg_resources.
7	- Declare support for Python 3.13.
8	+- Add preliminary support for Python 3.14.
9
10	1.0 (2024-07-16)
11	================
12
13	=== modified file 'storm/sqlobject.py'
14	--- storm/sqlobject.py 2024-03-13 16:25:17 +0000
15	+++ storm/sqlobject.py 2025-05-13 17:04:35 +0000
16	@@ -165,6 +165,8 @@
17	for attr, prop in list(dict.items()):
18	if attr == "__classcell__": # Python >= 3.6
19	continue
20	+ elif attr == "__classdictcell__": # Python >= 3.14
21	+ continue
22	attr_to_prop[attr] = attr
23	if isinstance(prop, ForeignKey):
24	db_name = prop.kwargs.get("dbName", attr)
25
26	=== modified file 'tox.ini'
27	--- tox.ini 2024-10-13 21:03:16 +0000
28	+++ tox.ini 2025-05-13 17:04:35 +0000
29	@@ -8,6 +8,7 @@
30	py311-{cextensions,nocextensions}
31	py312-{cextensions,nocextensions}
32	py313-{cextensions,nocextensions}
33	+ py314-{cextensions,nocextensions}
34	docs
35
36	[testenv]