Skip to content

drop support for user-defined databases #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

Image for: Conversation
Copy link
Contributor

Pull Request Template for Rcpp

Closes #1313.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog
Copy link
Member

Nice catch in #1313. I don't even recall what those user-define dbs were....

Copy link
Member

I am kinda minutes/hours/days from a new release so how would you feel if I delayed this til after the release. Given that @mattfidler saw this I would think we need a full rev.dep check (as we change the API surface) which I would rather avoid now. Thoughts?

Copy link
Contributor Author

For sure, definitely no rush on this (or the other PR I just put up).

Copy link

mattfidler commented Jul 5, 2024

For me I worked around it, if CRAN does ask for an update I am ready.

I dont mind waiting either.

Copy link
Member

Reverse dependency check is now 50% done, no new regressions yet.

Copy link
Member

The reverse depends run had no new issues, so merging this now. Had to do a micro-commit over conflicts in ChangeLog, will do one more clean-up (fixing tabs/spaces etc) once merged and once I increment the micro release.

eddelbuettel merged commit d303f9e into master Jul 22, 2024
16 checks passed
eddelbuettel deleted the bugfix/user-defined-database-drop-support branch August 20, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants