Skip to content

Support Authors@R in Rcpp.package.skeleton() #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2024
Merged

Support Authors@R in Rcpp.package.skeleton() #1325

merged 2 commits into from
Aug 28, 2024

Conversation

Image for: Conversation
Copy link
Member

This small PR changes the helper function creating an Rcpp package to use an Authors@R entry with c("aut", "cre"). Tests have bee adjusted; we just to test for Author and Maintainer being set so now we check for Authors@R and ... Date.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog
kevinushey approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
eddelbuettel merged commit 1e82f18 into master Aug 28, 2024
18 checks passed
eddelbuettel deleted the feature/skel_w_authors_at_r branch August 28, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants