Skip to content

tests: mock calls to systemctl #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

tests: mock calls to systemctl #314

merged 1 commit into from
Jan 18, 2023

Conversation

Image for: Conversation
Copy link
Contributor

Some tests were failing in sbuild due to calls to systemctl. It would check if networkd was running and try to start it. In my system the same happens except these tests get stuck asking for my password if I stop networkd.

Description

Image for: Description

Checklist

Image for: Checklist
  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.
tests: mock calls to systemctl
f143a34 
Some tests were failing in sbuild due to calls to systemctl. It would
check if networkd was running and try to start it. In my system the same
happens except these tests get stuck asking for my password if I stop
networkd.
slyon approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm.
slyon merged commit cab830c into canonical:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants