Add all the commands to the bash completion file (LP: #1749869) #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file was regenerated using the completely tool [0]. In the future we could do that in netplan itself using what we add to the argparse instance. [0] - https://github.com/DannyBen/completely
slyon
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Thank LGTM. Using completely sounds like a sensible choice and should make it much easier to keep this updated in the future!
I wonder if we could add some more dynamic bits to it, like suggesting network interfaces names on netplan status ... (see my inline comment).
In the future, we could also try to suggest querying the config via netplan get/set [network.[ethernets.[NETDEF_ID.[VALUE]]]] dynamically. But I think this is out of scope for now, as getting the config requires root permissions for now, which we cannot use inside the bash completions.
Enable the autocomplete to suggest network interfaces to netplan status. Regenerate the netplan.completions file. Co-authored-by: Lukas Märdian <slyon@ubuntu.com>
daniloegea
force-pushed
the
shell_autocomplete
branch
from
February 23, 2023 15:23
977f7e6 to
bb5227d
Compare
daniloegea
added a commit
that referenced
this pull request
May 17, 2023
* Add all the commands to the bash completion file The file was regenerated using the completely tool [0]. In the future we could do that in netplan itself using what we add to the argparse instance. [0] - https://github.com/DannyBen/completely * Update tools/completely.yaml Enable the autocomplete to suggest network interfaces to netplan status. Regenerate the netplan.completions file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file was (lazily) regenerated using the completely tool [0].
In the future we could do that in netplan itself using what we add to the argparse instance.
[0] - https://github.com/DannyBen/completely
Description
In the future we could try to add a builtin command similar to what
kubectl completiondoes and generate the script using argparse as source of information. Something likenetplan completion [bash|zsh].Checklist
make checksuccessfully.make check-coverage).