Skip to content

vrfs: skip policies parsing if list is NULL (LP: #2016427) #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2023
Merged

vrfs: skip policies parsing if list is NULL (LP: #2016427) #341

merged 2 commits into from
Apr 24, 2023

Conversation

Image for: Conversation
Copy link
Contributor

daniloegea commented Apr 17, 2023 •
edited by slyon
Loading

It addresses LP: #2016427

Description

Image for: Description

Checklist

Image for: Checklist
  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad. LP#2016427
daniloegea requested a review from slyon April 17, 2023 16:27
Copy link
Contributor Author

Actually, I suppose we should allow routing-policies without routes as well, right?
slyon approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!
slyon merged commit b062ead into canonical:main Apr 24, 2023
daniloegea added a commit that referenced this pull request May 17, 2023
vrfs: skip policies parsing if list is NULL (LP: #2016427) (#341)
15a422d 
* vrfs: skip policies parsing if list is NULL

It addresses LP: #2016427

* vrf: allow definition of policies without routes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants