Expose macaddress and DNS configuration from the netdef #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 16, 2023 11:56
Add iterators for nameservers and search domains.
slyon
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Thanks, lgtm!
This is addressing remarks I had wrt #386
I like that you refactored the address_iterator right away (even though, it's still considered to be NETPLAN_INTERNAL API). So we don't need to break that (internal) API with the next version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a property to retrieve the macaddress field from the netdef.
Refactor the addresses iterator to comply with our naming standards as advised in the PR #386 code review.
Add iterators for DNS nameservers and search domains following the naming standards as mentioned above.
Checklist
make checksuccessfully.make check-coverage).