Skip to content

Create single-nic-vm-host.md #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 19, 2024
Merged

Create single-nic-vm-host.md #475

merged 6 commits into from
Jun 19, 2024

Conversation

Image for: Conversation
Copy link
Contributor

Description

Image for: Description

This how to covers the scenario of a single NIC virtual machine host based on Ubuntu, and walks users through the required configuration steps using netplan and virsh.

Checklist

Image for: Checklist
  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.
Create single-nic-vm-host.md
9662082 
This how to covers the scenario of a single NIC virtual machine host based on Ubuntu, and walks users through the required configuration steps using netplan and virsh.
slyon requested a review from rkratky May 29, 2024 09:29
slyon added community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. documentation Documentation improvements. labels May 29, 2024
slyon reviewed May 29, 2024
View reviewed changes
Copy link
Collaborator

slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to Netplan!

Some initial comments from my side, but let's wait for Robert's feedback as well.
Apply suggestions from code review
3423ed5 
Co-authored-by: Lukas Märdian <slyon@ubuntu.com>
rkratky requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have more formatting suggestions, and doing it through GH comments would be a bit cumbersome, so I'm going to submit a PR against Mauro's branch.
slyon added the Canonical by Canonical employees outside the Netplan team label Jun 5, 2024
ilvipero and others added 4 commits June 6, 2024 13:22
Update doc/single-nic-vm-host.md
b72cd88 
Co-authored-by: Robert Krátký <robert.kratky@canonical.com>
Update doc/single-nic-vm-host.md
eae8ca3 
Co-authored-by: Robert Krátký <robert.kratky@canonical.com>
Reformat the single-nic-vm-host howto.
4bc54f2
Merge pull request #1 from rkratky/pr-475
8a1abb7 
Reformat the single-nic-vm-host howto
Copy link
Collaborator

slyon commented Jun 19, 2024

FTR: some fixes landed via ilvipero#1
slyon approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm with the latest fixes!
slyon merged commit e5f4edd into canonical:main Jun 19, 2024
4 of 5 checks passed
slyon mentioned this pull request Jun 19, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Canonical by Canonical employees outside the Netplan team community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. documentation Documentation improvements.
3 participants