Skip to content

Use gsl from the system, via pkg-config when available. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

Image for: Conversation
Copy link
Contributor

This patch switches to using gsl from the system, when available via pkg-config or otherwise using hard-coded library dependencies. It makes the package work with gsl from Rtools42-45. Behavior with previous versions of R is not affected, as this uses the .ucrt version of Makevars.

This silences a warning (now on CRAN results) about using non-allowed external symbols.

Copy link
Owner

Thank you so much -- I saw that on the CRAN results and was planning to ping you. I really appreciate that you got there first.

Copy link
Owner

If you have a second to add a ChangeLog entry, I would as always appreciate one. Else I can carry it over from the RQuantLib fix.

Copy link
Contributor Author

Sure, I added a ChangeLog entry.

Copy link
Owner

Thanks. I may wait the polite week to avoid the nag on 'you just uploaded' and then refresh the package at CRAN. I should add an appropriate startup message that users may want to migrate to zigg which is just the PRNGs, and no comparison implementations -- which is what gets is the GSL tail here.

eddelbuettel merged commit 9ae3994 into eddelbuettel:master Mar 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants