Skip to content

Fix building on Ubuntu 22.10 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Image for: Conversation
Copy link
Contributor

With this version of the code I can build & run it on both Ubuntu and macOs

Copy link
Owner

Will test in a bit!

Copy link
Owner

No luck yet (when working off your branch)

edd@rob:/tmp/rcpp/rinside/rinside/inst/examples/qt/build(master)$ cmake -S ../cmake/ -G "Unix Makefiles"
CMake Error at /usr/share/cmake-3.24/Modules/FindQt4.cmake:1314 (message):
  Found unsuitable Qt version "" from NOTFOUND, this code requires Qt 4.x
Call Stack (most recent call first):
  CMakeLists.txt:5 (find_package)


-- Configuring incomplete, errors occurred!
See also "/tmp/rcpp/rinside/rinside/inst/examples/qt/build/CMakeFiles/CMakeOutput.log".
edd@rob:/tmp/rcpp/rinside/rinside/inst/examples/qt/build(master)$ 
Copy link
Contributor Author

JorisGoosen commented Mar 14, 2023

The errormessage sounds rather like you are using an older version of the code as it looks for Qt4 instead of Qt6.
Also in your copy-paste:

edd@rob:/tmp/rcpp/rinside/rinside/inst/examples/qt/build(master)$

Perhaps the old local master is checked out?

Copy link
Owner

Doh. Quite possibly. Was in a rush. So sorry!

Works perfectly fine (modulo too much compiler noise from Rcpp, whoops) when I am on the correct branch.

eddelbuettel force-pushed the fixQtDensityDemoUbuntu branch from 954ee2b to 23dd027 Compare March 14, 2023 22:54
Copy link
Owner

eddelbuettel commented Mar 14, 2023

To make up for the whoops I allowed myself a rebase and push back to you -- this PR is now cleanly one commit ahead of master.

eddelbuettel merged commit 682dda0 into eddelbuettel:master Mar 14, 2023
Copy link
Contributor Author

Thanks for the test and Ill get back to you once I feel up to fighting with Windows again, as I do need to use RInside with Qt there anyway...

Copy link
Owner

As maintainer, I am quite happy to not insist on Windows. I once or twice ages went through all the hoops to demonstrate it works but Linux and macOS are simply much more important.

So to me the only TODO (on my end) is to add you to ChangeLog and NEWS for the two quick PRs. Thanks again for both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants