Tidy: use internal concatenation to build error

[MichaelChirico]

As found by condition_message_linter().

We might also prefer gettextf() for internationalization but that's a much bigger project.

[eddelbuettel]

Valid point.

[ Also note that the package is pre-Rcpp and uses .Call() everywhere. Changing that would be nice. "Bigger project still. " ]

Maybe it is time we hand this package over to you guys, and/or you start maintaining an internal fork.

[eddelbuettel]

I can probably merge it if you please add a ChangeLog entry.

[MichaelChirico]

Maybe it is time we hand this package over to you guys, and/or you start maintaining an internal fork.

I'm afraid you're still (by a pretty wide margin?) the person with the best understanding of the code base & eng support is unfortunately lacking on our end :(

But do feel free to assign issues to us (me 😄) & if you're dying to pass off maintainership, please flag & I'll see what we can do.

[eddelbuettel]

Thanks!

[murraystokely]

Glad to see you guys are still using this at Google. =) We used it at Apple some but it wasn't as useful as without the global protodb in google3 (or whatever the equivalent is now, ten years later). - Murray

…

On Tue, May 28, 2024 at 1:55 PM Michael Chirico ***@***.***> wrote: Maybe it is time we hand this package over to you guys, and/or you start maintaining an internal fork. I'm afraid you're still (by a pretty wide margin?) the person with the best understanding of the code base & eng support is unfortunately lacking on our end :( But do feel free to assign issues to us (me 😄) & if you're dying to pass off maintainership, please flag & I'll see what we can do. — Reply to this email directly, view it on GitHub <#102 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGC53L62KRWE2GDOTW7HLTZETVLVAVCNFSM6AAAAABINTFKQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZWGA4DQNZZHE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[eddelbuettel]

You are way overestimating my familiarity with the code base, but I do still know which buttons to press to keep it in good standing at CRAN. The effective modus operandi here where all changes come from an unnamed large tech company which may be deploying this internally works for now.

[MichaelChirico]

Glad to see you guys are still using this at Google. =) We used it at Apple some but it wasn't as useful as without the global protodb in google3 (or whatever the equivalent is now, ten years later). - Murray

Nice seeing you Murray! More used to seeing your signature on blames deep in R infra here :)

Global DB lives on 🤘