Skip to content

RProtoBuf compatible with protobuf >= 26.x #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

Image for: Conversation
Copy link
Contributor

TeoGiane commented Jul 2, 2024

As stated in the Release Notes, protobuf version 26.0 includes breaking changes to C++ and other languages.
This causes RProtoBuf fail to get installed in case the version of protobuf is up to latest release.

This PR makes RProtoBuf compatible with this new changes in the code.

NOTE In wrapper_Message.cpp in this new version the always_print_primitive_fields has been removed. I personally did the minimal effort to make the package up and running, but maybe some additional work should be done.

Hope it helps.

Copy link
Owner

Much appreciated. I think I will merge this even though I would prefer to test it properly but given that I mostly rely on pre-packaged Debian packages, and those may not have gotten to 26.x yet.

eddelbuettel merged commit 9820bf2 into eddelbuettel:master Jul 2, 2024
2 checks passed
Copy link
Contributor Author

TeoGiane commented Jul 3, 2024

Completely agree. Thank you very much, @eddelbuettel! Do not hesitate to contact me is dome issues arises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants