Fix incorrect bindings for enum value descriptors #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to send a PR! Would you mind adding a ChangeLog entry? C-x 4 a in Emacs, otherwise maybe look at existing entries. Two spaces between fields in the header line. |
|
Sure thing, thanks for the quick response! |
eddelbuettel
pushed a commit
that referenced
this pull request
Feb 11, 2025
* Fix incorrect FFI bindings for enum value descriptors * Add changelog
|
Small postscriptum: What was added to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens to work today because the memory layout of EnumDescriptor and EnumValueDescriptor match. If this changes (which it will in a coming release), it results in memory corruption and UB.