Add a Notifications DBus Property #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 2, 2025
Queuecumber
force-pushed
the
dbus-notifications
branch
from
April 2, 2025 14:21
2418662 to
d8a24dc
Compare
Signed-off-by: Max Ehrlich <max.ehr@gmail.com>
Queuecumber
force-pushed
the
dbus-notifications
branch
from
April 2, 2025 14:22
d8a24dc to
82139bd
Compare
grmat
reviewed
Apr 16, 2025
| @@ -140,6 +140,8 @@ void close_notification(struct mako_notification *notif, | |||
| } else { | |||
| destroy_notification(notif); | |||
| } | |||
|
|
|||
| emit_notifications_changed(notif->state); | |||
There was a problem hiding this comment.
notif has already been freed here in case you don't want it added to the history.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Notificationsproperty to the Mako DBus object, this holds the current list of notifications in the same format as theListNotificationsmethod and publishes state changes when notifications are added or removed.The intention is that other applications wishing to respond to Mako's state can easily do so.
This is a followup from #578