Skip to content

Add frame numbers to the flutter frames chart in the performance page #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2021
Merged

Add frame numbers to the flutter frames chart in the performance page #3526

merged 1 commit into from
Dec 9, 2021

Conversation

Image for: Conversation
Copy link
Member

Work towards #3485, specifically addressing the feedback here - @ayanogawa

When the frame analysis feature is turned on, these numbers will match the frame tab titles:
kenzieschmoll merged commit b4e4043 into flutter:master Dec 9, 2021
kenzieschmoll deleted the numbered-frames branch December 9, 2021 16:26
Copy link

Awesome work!
For the magnifying glasses, can we style it like the attachment?
Circle - .8 opacity of #303030, 20 X 20 px
Magnifying glass - #ffffff, 12 X 12 px

Thank you in advance.
kenzieschmoll mentioned this pull request Dec 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants