-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[url_launcher] Mark Link as an invisible factory #4578
Conversation
This improves performance, as the Flutter engine is given a signal that it doesn't need to create an overlay to render links.
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Looks like the PR will need to stay open until 2.9 or later reaches stable. |
Is it time to submit this? |
Was it cherry-picked to 2.8? If not, we need to wait for the next stable release. |
This and flutter/packages#529 are waiting for 2.10 to roll into |
Waiting for this benchmark to land: |
Updating PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go! 2.10 is already stable!
This breaks people who are still on 2.8, because the min Flutter version wasn't updated; we're getting reports about it. While we don't officially support anything but latest stable, we ideally shouldn't leave people on older versions broken. I suggest reverting this (as a new version, which we publish), then re-landing with 2.10 minumum as another new version. |
Actually, I forgot about the new retraction feature. I retracted 2.0.7, and we can just rev the min in a 2.0.8. I'll send a PR now. |
This improves performance, as the Flutter engine is given a signal that it doesn't need to create an overlay to render links.
This optimization requires flutter/engine#30003
Fixes flutter/flutter#94640
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.