Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] Mark Link as an invisible factory #4578

Merged
merged 6 commits into from
Feb 4, 2022
Merged

[url_launcher] Mark Link as an invisible factory #4578

merged 6 commits into from
Feb 4, 2022

Conversation

Image for: Conversation
Copy link
Contributor

harryterkelsen commented Dec 4, 2021

This improves performance, as the Flutter engine is given a signal that it doesn't need to create an overlay to render links.

This optimization requires flutter/engine#30003

Fixes flutter/flutter#94640

Pre-launch Checklist

Image for: Pre-launch Checklist
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This improves performance, as the Flutter engine is given a signal
that it doesn't need to create an overlay to render links.
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

This optimization requires flutter/engine#30003

Looks like the PR will need to stay open until 2.9 or later reaches stable.

godofredoc changed the base branch from master to main January 6, 2022 22:38
Copy link
Contributor

yjbanov commented Jan 21, 2022

Is it time to submit this?

Copy link
Contributor

Is it time to submit this?

Was it cherry-picked to 2.8? If not, we need to wait for the next stable release.

Copy link
Member

ditman commented Jan 31, 2022

This and flutter/packages#529 are waiting for 2.10 to roll into stable.

Copy link
Member

ditman commented Feb 3, 2022

Waiting for this benchmark to land:

flutter/flutter#94638

Copy link
Member

ditman commented Feb 4, 2022

Updating PR

Copy link
Member

ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! 2.10 is already stable!

ditman added last mile waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. labels Feb 4, 2022
Copy link
Contributor

This breaks people who are still on 2.8, because the min Flutter version wasn't updated; we're getting reports about it.

While we don't officially support anything but latest stable, we ideally shouldn't leave people on older versions broken. I suggest reverting this (as a new version, which we publish), then re-landing with 2.10 minumum as another new version.

Copy link
Contributor

Actually, I forgot about the new retraction feature. I retracted 2.0.7, and we can just rev the min in a 2.0.8. I'll send a PR now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes needs tests p: url_launcher platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
5 participants