-
Notifications
You must be signed in to change notification settings - Fork 710
Document the remote-repo-cache
option as is implemented (it is).
#8738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the remote-repo-cache
option as is implemented (it is).
#8738
Conversation
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, are we sure this works in general and not in one easy corner case?
I could test in some other cases if that would help. Can you give me an idea of what the general problem space is? I just learned about this option today and as far as I can tell "specify a different directory" like in the example is the only thing you can do with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah, I've never used this option, so I don't have any idea. Could anybody toss any other use case for this feature so that we could try?
@exarkun: feel free to set the merge_me label and this will still leave 2 days for people to come up with evil examples to try.
I can't think of trickier examples, but I think if anyone wanted to get to the bottom of it, one could investigate what patch changed the state of things and what that patch had to say about all of that. But that maybe too much effort for such a small thing. It's more efficient to apply the current change and wait for bug reports! In the meantime we have many more "pr-welcome" issues that @exarkun or anyone else could spend their energy for. |
Let me rebase to apply one more CI fix. |
@mergify rebase |
❌ Pull request can't be updated with latest base branch changesMergify needs the author permission to update the base branch of the pull request. |
@exarkun: could you let admins write to your branch or, alternatively, rebase youself? Thank you. |
74f3bc1
to
8dc8b3d
Compare
@Mikolaj rebased (I would grant permission too but I can't find that github button today...) |
@mergify refresh |
✅ Pull request refreshed |
Apparently that blocks auto-merging, too. so let me merge manually. |
@exarkun: thank you again! |
Fixes #8737
Please include the following checklist in your PR:
I tested that the feature really is implemented and left a transcript on the issue. I tested that the docs build and render using Python 3.8 on NixOS 22.11 in a virtualenv using the
requirements.txt
in the repo and visual inspection.