Skip to content

Document the remote-repo-cache option as is implemented (it is). #8738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

Image for: Conversation
Copy link
Collaborator

exarkun commented Feb 7, 2023

Fixes #8737


Please include the following checklist in your PR:

I tested that the feature really is implemented and left a transcript on the issue. I tested that the docs build and render using Python 3.8 on NixOS 22.11 in a virtualenv using the requirements.txt in the repo and visual inspection.

Copy link
Collaborator

Thank you!

Copy link
Member

Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, are we sure this works in general and not in one easy corner case?

Copy link
Collaborator Author

exarkun commented Feb 7, 2023

However, are we sure this works in general and not in one easy corner case?

I could test in some other cases if that would help. Can you give me an idea of what the general problem space is? I just learned about this option today and as far as I can tell "specify a different directory" like in the example is the only thing you can do with it.

Copy link
Member

Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, I've never used this option, so I don't have any idea. Could anybody toss any other use case for this feature so that we could try?

@exarkun: feel free to set the merge_me label and this will still leave 2 days for people to come up with evil examples to try.

exarkun added the merge me Tell Mergify Bot to merge label Feb 7, 2023
Copy link
Collaborator

I can't think of trickier examples, but I think if anyone wanted to get to the bottom of it, one could investigate what patch changed the state of things and what that patch had to say about all of that. But that maybe too much effort for such a small thing. It's more efficient to apply the current change and wait for bug reports! In the meantime we have many more "pr-welcome" issues that @exarkun or anyone else could spend their energy for.

mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Feb 9, 2023
Copy link
Member

Mikolaj commented Feb 9, 2023

Let me rebase to apply one more CI fix.

Copy link
Member

Mikolaj commented Feb 9, 2023

@mergify rebase

Copy link
Contributor

mergify bot commented Feb 9, 2023

rebase

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request.
@PrivateStorageio needs to authorize modification on its head branch.
err-code: 5E022

Copy link
Member

Mikolaj commented Feb 9, 2023

@exarkun: could you let admins write to your branch or, alternatively, rebase youself? Thank you.

exarkun force-pushed the document-remote-repo-cache branch from 74f3bc1 to 8dc8b3d Compare February 9, 2023 22:13
Copy link
Collaborator Author

exarkun commented Feb 9, 2023

@Mikolaj rebased (I would grant permission too but I can't find that github button today...)

Copy link
Member

Mikolaj commented Feb 10, 2023

@mergify refresh

Copy link
Contributor

mergify bot commented Feb 10, 2023

refresh

✅ Pull request refreshed

Copy link
Member

Mikolaj commented Feb 10, 2023

Apparently that blocks auto-merging, too. so let me merge manually.

Mikolaj merged commit 2152b30 into haskell:master Feb 10, 2023
Copy link
Member

Mikolaj commented Feb 10, 2023

@exarkun: thank you again!

exarkun deleted the document-remote-repo-cache branch February 10, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
3 participants