Skip to content

Fix jQuery #14535: Always setDocument() after iframe unload #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Image for: Conversation
Copy link
Member

   raw     gz Sizes
 57353  17341 dist/sizzle.js
 18335   7060 dist/sizzle.min.js

   raw     gz Compared to master @ 3c3c5f20f8289f4e943d11d93f5541af1b072667
  +192    +51 dist/sizzle.js
   +63    +25 dist/sizzle.min.js

😢

Copy link
Member

Doesn't this also disable bfcache? That would be a horror to inflict on everyone for the sins of one.

Copy link
Member Author

I believe it will, but keep in mind that the blast radius is reduced by this only applying to child windows.

Copy link
Member

👍

Copy link
Member

Oh true. That's probably less of an impact. There should be some way to limit this further to IE but I can't think of a safe one that won't similarly break in the future.

Copy link
Member Author

@timmywil @dmethvin Can you make sure this hits Sizzle and jQuery respectively before the release? I don't think I'll have the time for it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants