Skip to content

Make SVGUnitTypes a regular interface with only constants #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2016
Merged

Make SVGUnitTypes a regular interface with only constants #295

merged 1 commit into from
Nov 22, 2016

Conversation

Image for: Conversation
Copy link
Member

foolip commented Nov 16, 2016

Fixes #291.

Copy link
Member Author

foolip commented Nov 16, 2016

Must I be a WG member to write a PR? I'd rather not join for a one-off like this.

Copy link
Contributor

@foolip You don't have to be a WG member, but you do have to click OK to an IP agreement, acknowledging that your code & words are being freely contributed, etc.

PS, Thanks for writing this up.

Copy link
Member Author

foolip commented Nov 16, 2016

@AmeliaBR, where can I click "OK"? I tried following the "Details" link for the failed check but it looks like an admin view for the repo owner or something.

Copy link
Member

@foolip: Are you at Opera?
I think the issue is that Opera doesn't have any affiliation with the SVG WG anymore (maybe you should?).
My understanding is that the ash-nazg tool would allow contributions from you without you being a WG member, as long as you have a single Member-affiliation and that member is in the group.

I'll follow this up with @shepazu and get back to you. It may be that someone from Opera needs to join the WG, or you need to fill out one of these forms.

Copy link
Member Author

foolip commented Nov 17, 2016

@nikosandronikos no I'm at Google now.

Copy link
Member

(ip check solved. we just got an improvement earlier today to avoid failing on this type of cases)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants