-
Notifications
You must be signed in to change notification settings - Fork 137
Remove solidcolour #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove solidcolour #450
Conversation
master/pservers.html
Outdated
@@ -67,8 +66,7 @@ <h2 id="Introduction">Introduction</h2> | |||
<img | |||
alt="Image of three types of paint servers." | |||
src="images/pservers/pservers_example.png"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs someone to change the graphic (and alt text)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The png is based on: https://svgwg.org/svg2-draft/images/pservers/pservers_example.svg
Which is already coded in a web-compatible way (the "solid color" example is just a rect with color fill), so it's just a matter of editing out the extras & adjusting the coordinates & re-exporting the PNG. Or just delete the PNG and embed the SVG in the <img>
, since it would only include well-supported SVG 1.1 features.
I don't think there is any reason to update specs/color/* It is a legacy spec, not currently used anywhere that I know of. But maybe @svgeesus would know more about that. |
For this and some of the other changes, is it worth keeping the "Annotations", and updating them with the new resolutions? And maybe preserving target anchors, by incorporating them in those annotation notes, so that if someone is following a link to removed content, they will get some information about where it has gone & why. |
I prefer not to as it adds noise for people that don't know these features (which as they're not implemented will be most regular web developers) and I don't think other specs keep around things related to deferred/removed features outside of a changelog. Maybe we can add those links to the changelog (although I guess the URL wont work unless in single page more as the html page will be different and we don't redirect like HTML Living standard do if you link to a fragment identifier that has moved to a different page) or we can just link to SVG21 in the changelog where these features are mentioned once the URLs for those exist. |
@svgeesus do you have feedback from Amelia's question above about if we should change SVG Colour or leave as is? I'd like to get this PR merged soon if possible. |
In the interests of a speedy resolve, I've reverted the colour spec change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this and the cursor changes, are you able to also patch the changes into the svg-next branch? (To help distinguish the permanent removals from the deferments, and help us get ready for a 2.1 FPWD.)
I don't think you can do that in the GitHub interface, would need to use a separate git client.
I can look into it over the weekend. It might have to be a separate PRs as the original isolated PRs had merge conflicts where the other gradients were allowed on the same elements etc. |
w3c/svgwg#450 removed the <solidcolor> element and SVGSolidcolorElement interface from the SVG spec. w3c/svgwg@f05f02e
w3c/svgwg#450 removed the <solidcolor> element and SVGSolidcolorElement interface from the SVG spec. w3c/svgwg@f05f02e
No description provided.