Skip to content

pathLength does not affect percentage calculations #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2018

Conversation

Image for: Conversation
Copy link
Contributor

When values like startOffset are expressed as percentages,
pathLength has no effect. This includes when pathLength is 0.

resolves #383

When values like startOffset are expressed as percentages,
pathLength has no effect. This includes when pathLength is 0.

resolves w3c#383
ewilligers requested review from AmeliaBR and heycam July 8, 2018 12:42
Copy link
Member

The Working Group just discussed pathLength PR.

The full IRC log of that discussion <AmeliaBR> Topic: pathLength PR
<AmeliaBR> gitHub: https://github.com//pull/485
<liam> [are we on 485 or https://github.com//issues/383 ? ]
<liam> AmeliaBR, in most cases differences in path length adjustment will cancel out, but we have a special rule about handling path length of zero
<liam> and for a +ve length you go to the end of the path instead of the beginning
<liam> so the only change is to say that doesn't affect MISSED
<liam> Eric: any +ve non-% length goes to the end of the path
<AmeliaBR> s/MISSED/percentage length values/
<liam> Dirk: if that's implemnt behaviour it's fine with be
<liam> AmeliaBR: Eric - are there tests for the changes?
<liam> Eric: there were non-percent path lengths,haven't done zero with % but i'll add them now
<liam> AmeliaBR: need a review, ok with me
<ericwilligers> Any positive non-percentage lengths goes to the end of the path.
<liam> Eric: new proposal (see preceding IRC line)
<ericwilligers> Percentages resolve to 0 when pathLength is 0
<liam> Dirk: for 0 you'd get the end of the path but percentages resolve to zero
<ericwilligers> 0 is always the start of the path.
<liam> AmeliaBR: these are all edge cases anyway
<liam> Eric: I'll send a new pr and tests.
<ericwilligers> https://github.com//issues/484
AmeliaBR merged commit c3ff957 into w3c:master Aug 13, 2018
AmeliaBR added a commit that referenced this pull request Aug 13, 2018
- Add issue/PR links to the changes that were just merged (PR #485 and #430),
  to be consistent with patterns from PR #521
  (Next time, need to remember to do this before merging!)

- Used consistent wording for removed appendices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants