Change from HTML 5.1 to HTML LS, #514 #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
ready for review |
|
Haven't reviewed yet, but: I think this might be a good use case for the "squash & merge" feature. |
|
Probably :) I thought small, single-purpose commits with meaningful names might be easier to check though |
|
Any other takers for a quick review? |
|
I think it is better to merge this now because other PR in the queue are likely to clobber it due to lots of text being moved around. The edits on this PR are very small and localized (updating hrefs from HTML5 to HTML LS) |
AmeliaBR
reviewed
Sep 21, 2018
| @@ -638,7 +638,7 @@ <h3 id="PaintingRasterImages">Painting raster images</h3> | |||
| requirements are discussed under | |||
| <a href="conform.html">conformance requirements</a>.</p> | |||
| <p class="ready-for-wider-review"> | |||
| As in HTML [<a href="refs.html#ref-html51">HTML</a>, 10.4.2], | |||
| As in HTML [<a href="refs.html#ref-html">HTML</a>, 10.4.2], | |||
There was a problem hiding this comment.
With a belated review comment: that section number is wrong. Haven't tracked down the correct one.
If you have a chance, it could be fixed as a separate commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all internal links to [HTML] which were linking to HTML 5.1 in the refs (with the wrong bibliographic reference). Actual [HTML51] was not found.