-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Update to reference SVG 2 #3692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove reference to SVG 1.1 and SVG Tiny
I liked to the SVG draft as the current CR hasn't been updated yet with all the removals mentioned in the HTML spec. I wasn't sure if this is appropriate, but we can always update once we publish the next PR/CR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits around the introductory material, but the hard parts look great.
We actually always use the editor's drafts in the references, so even if there were a CR or other TR, we wouldn't want to reference it.
source
Outdated
<li>The <code data-x="">tabindex</code> attribute is allowed on visible SVG elements</li> | ||
<li>The ARIA accessibility attributes are allowed on all SVG elements</li> | ||
</ul> | ||
<p>User agents that implement SVG must not implement the SVG 2 specification</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence doesn't seem quite right :). Maybe must implement the <cite>SVG 2</cite> specification, and not any earlier revisions
? And don't forget the period ending the paragraph.
source
Outdated
<li>The <code data-x="">tabindex</code> attribute is allowed on visible SVG elements</li> | ||
<li>The ARIA accessibility attributes are allowed on all SVG elements</li> | ||
</ul> | ||
<p>User agents that implement SVG must not implement the SVG 2 specification</p> | ||
|
||
<p>The following features are defined in the SVG specifications:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that there's only one, this doesn't need to be plural.
I think this one is ready now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Oh, did you want to add yourself the acknowledgments section?
I think I'm already there now. |
Thanks! |
Remove reference to SVG 1.1 and SVG Tiny
Fixes #3679
/canvas.html ( diff )
/dom.html ( diff )
/embedded-content-other.html ( diff )
/form-elements.html ( diff )
/imagebitmap-and-animations.html ( diff )
/indices.html ( diff )
/infrastructure.html ( diff )
/microdata.html ( diff )
/parsing.html ( diff )
/references.html ( diff )